lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Sep 2014 17:24:55 +0200 From: Petr Mládek <pmladek@...e.cz> To: Alan Stern <stern@...land.harvard.edu> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Tejun Heo <tj@...nel.org>, Joe Lawrence <joe.lawrence@...atus.com>, Jiri Kosina <jkosina@...e.cz>, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/4] usb: hub: remove obsolete while cycle in hub_event() On Fri 12-09-14 10:23:26, Alan Stern wrote: > On Fri, 12 Sep 2014, Petr Mladek wrote: > > > The USB hub events are proceed by workqueue instead of kthread now. > > The result is that hub_event() function processes only one event. > > The while cycle was not removed earlier to show the real changes when > > switching to the workqueue. > > > > This patch also consolidates the goto targets and rename them from "loop*" > > to "out*". > > > > When touching the code, it fixes also formatting of dev_err() and dev_dbg() > > calls to make checkpatch.pl happy :-) > > Although the reason given in the description above is not really > accurate, removing the loop in hub_events is a reasonable thing to do. > That loop doesn't serve any purpose as far as I can see. IMHO, the while cycle was needed when hub_events() was used in khubd thread. More events could had been added to the list before the thread was scheduled. Therefore I think that the above description makes sense. And this is why I did not change the order of the patches in v2 of the patch set. I sent all patches again because this one and the 3rd one needed refresh. Best Regards, Petr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists