linux-kernel - Re: [PATCH] mfd: ssbi: promote the driver to subsys level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140917160305.GH30918@lee--X1>
Date:	Wed, 17 Sep 2014 09:03:05 -0700
From:	Lee Jones <lee.jones@...aro.org>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:	David Brown <davidb@...eaurora.org>,
	Daniel Walker <dwalker@...o99.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: ssbi: promote the driver to subsys level

On Wed, 17 Sep 2014, Srinivas Kandagatla wrote:

> This patch promtes the driver to be at subsystem level as this driver
> will be used by gpio controller drivers which inturn are used by many
> platform drivers.

Any reason why you're not using -EPROBE?

> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
>  drivers/mfd/ssbi.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c
> index b78942e..4fbe02e 100644
> --- a/drivers/mfd/ssbi.c
> +++ b/drivers/mfd/ssbi.c
> @@ -331,7 +331,12 @@ static struct platform_driver ssbi_driver = {
>  		.of_match_table = ssbi_match_table,
>  	},
>  };
> -module_platform_driver(ssbi_driver);
> +
> +static int ssbi_init(void)
> +{
> +	return platform_driver_register(&ssbi_driver);
> +}
> +subsys_initcall(ssbi_init);
>  
>  MODULE_LICENSE("GPL v2");
>  MODULE_VERSION("1.0");

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/