linux-kernel - Re: [PATCH] x86: thinkpad_acpi.c: fixed spacing coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140917162058.GB5697@vmdeb7>
Date:	Wed, 17 Sep 2014 09:20:58 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	Henrique de Moraes Holschuh <hmh@....eng.br>
Cc:	Jan van den Berg <janvdberg@...il.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: thinkpad_acpi.c: fixed spacing coding style issue

On Wed, Sep 17, 2014 at 09:48:35AM -0300, Henrique de Moraes Holschuh wrote:
> On Wed, 17 Sep 2014, Jan van den Berg wrote:
> > I will try and make _real_ contribution next time. (With this being my
> > first ever submission to the kernel: at least now I understand the kernel
> > workflow.)
> 
> There's nothing wrong with your patch by itself.  And git does try to help
> us take such patches (there's "git blame -w")... but ignoring whitespace
> changes doesn't always work as well as one would like.
> 
> That said, Darren has already queued your patch, and I am _not_ going to ask
> him to drop it.  So, as far as I'm concerned, the patch has been accepted,
> and that's it.

Henrique,

Thanks for the feedback. I had considered rejecting the patch for the reason you
describe, but opted to take it this time. I haven't established all my
maintainer policies yet, so they will change a little over time as we find what
works and what causes us more pain. Personally, I like to see the cleanups, but
generally agree that cleanups should typically be [PATCH 1/X] of a series.

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/