linux-kernel - Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Sep 2014 18:55:30 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Nishanth Menon <nm@...com>, Samuel Ortiz <sameo@...ux.intel.com>,
	Tony Lindgren <tony@...mide.com>, linux-omap@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power:
 Use the standard 'ti,system-power-controller' to mark power control

On Wed, Sep 17, 2014 at 08:44:00AM -0700, Lee Jones wrote:
> On Wed, 17 Sep 2014, Nishanth Menon wrote:
> > ti,system-power-controller is more or less the standard way of
> > indicating that the PMIC is the system wide power controller and hence
> > may be used to switch off the system. Almost ALL TI PMIC drivers and
> > many Maxim PMIC drivers follow the same style.
> > 
> > So support 'ti,system-power-controller' in addition to the usual
> > 'ti,use_poweroff' to indicate that the PMIC instance has control for
> > switching off the system.
> > 
> > Signed-off-by: Nishanth Menon <nm@...com>
> > ---
> > 
> > V2: picked up documentation suggestion from Sebastien
> 
> It would be good to get Sebastian's Ack.

Acked-By: Sebastian Reichel <sre@...nel.org>

[...]

> > +- ti,system-power-controller: This indicates that TWL4030 is the
> > +  power supply master of the system. With this flag, the chip will
> > +  initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
> > +  system poweroffs.

One minor thing: While the documentation is updated you may want to
fix the typo "will initiates" to "will initiate" (or just drop the
"will").

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)