| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Sep 2014 23:47:27 +0200 From: Frans Klaver <fransklaver@...il.com> To: Darren Hart <dvhart@...radead.org> Cc: Frans Klaver <fransklaver@...il.com>, Corentin Chary <corentin.chary@...il.com>, Rafael Wysocki <rafael.j.wysocki@...el.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, acpi4asus-user@...ts.sourceforge.net, platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH 9/9] eeepc-laptop: store_cpufv: return error if set_acpi fails The result of set_acpi is left unchecked, but it may return errors. If one occurs, send the error to the caller. There's no reason to lie about it, if set_acpi fails. Signed-off-by: Frans Klaver <fransklaver@...il.com> --- drivers/platform/x86/eeepc-laptop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c index 875a43f..3f6c762 100644 --- a/drivers/platform/x86/eeepc-laptop.c +++ b/drivers/platform/x86/eeepc-laptop.c @@ -388,7 +388,9 @@ static ssize_t cpufv_store(struct device *dev, return rv; if (value < 0 || value >= c.num) return -EINVAL; - set_acpi(eeepc, CM_ASL_CPUFV, value); + rv = set_acpi(eeepc, CM_ASL_CPUFV, value); + if (rv) + return rv; return count; } -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists