linux-kernel - Re: [PATCHv2] pinctrl: baytrail: Clear DIRECT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140918095349.GH10854@lahna.fi.intel.com>
Date:	Thu, 18 Sep 2014 12:53:49 +0300
From:	Mika Westerberg <mika.westerberg@...el.com>
To:	Loic Poulain <loic.poulain@...el.com>
Cc:	linus.walleij@...aro.org, heikki.krogerus@...ux.intel.com,
	mathias.nyman@...ux.intel.com, samuel.ortiz@...el.com,
	linux-kernel@...r.kernel.org,
	Eric Ernst <eric.ernst@...ux.intel.com>
Subject: Re: [PATCHv2] pinctrl: baytrail: Clear DIRECT_IRQ bit

On Thu, Sep 18, 2014 at 11:31:35AM +0200, Loic Poulain wrote:
> Warn seems necessary because we unconditionally change
> the pin behavior, I didn't meet any case where direct irq is truly
> used on our platform. But maybe it could happen?
> Don't want to cause any hidden regression.

The datasheet says 

"""
This bit should be cleared if io access mode is selected
for this pad
"""

If I interpret it right, it means that whenever this pad is functioning
as a GPIO the flag should be cleared. That's precisely the case here.

> Moreover if it is confirmed that is an hardware issue (BIOS),
> We can just keep this patch locally as a workaround and revert
> it later once our BIOS fixed.

True but only if there aren't any machines out there with this flaw in
the BIOS.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/