linux-kernel - Re: [PATCH v2 7/7] arm: mediatek: Add earlyprintk support for mt8127 & mt8135

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <541AD7A2.9020008@gmail.com>
Date:	Thu, 18 Sep 2014 15:01:22 +0200
From:	Matthias Brugger <matthias.bgg@...il.com>
To:	"Joe.C" <srv_yingjoe.chen@...iatek.com>,
	Rob Herring <robh+dt@...nel.org>, arm@...nel.org
CC:	linux-arm-kernel@...ts.infradead.org, srv_heupstream@...iatek.com,
	yingjoe.chen@...il.com, yingjoe.chen@...iatek.com,
	hc.yen@...iatek.com, eddie.huang@...iatek.com,
	nathan.chung@...iatek.com, yh.chen@...iatek.com,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	Linus Walleij <linus.walleij@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	Anders Berg <anders.berg@....com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 7/7] arm: mediatek: Add earlyprintk support for mt8127
 & mt8135



On 17/09/14 16:24, Joe.C wrote:
> From: "Joe.C" <yingjoe.chen@...iatek.com>
> 
> Enable low-level debug for Mediatek mt8127 & mt8135 SoC.
> 
> Signed-off-by: Joe.C <yingjoe.chen@...iatek.com>
> ---
>  arch/arm/Kconfig.debug | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index cfdd1c0..3888d17 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -842,6 +842,22 @@ choice
>  		  Say Y here if you want kernel low-level debugging support
>  		  for Mediatek mt6589 based platforms on UART0.
>  
> +	config DEBUG_MT8127_UART0
> +		bool "Mediatek mt8127 UART0"
> +		depends on ARCH_MEDIATEK
> +		select DEBUG_UART_8250
> +		help
> +		  Say Y here if you want kernel low-level debugging support
> +		  for Mediatek mt8127 based platforms on UART0.
> +
> +	config DEBUG_MT8135_UART3
> +		bool "Mediatek mt8135 UART3"
> +		depends on ARCH_MEDIATEK
> +		select DEBUG_UART_8250
> +		help
> +		  Say Y here if you want kernel low-level debugging support
> +		  for Mediatek mt8135 based platforms on UART3.
> +
>  	config DEBUG_VEXPRESS_UART0_DETECT
>  		bool "Autodetect UART0 on Versatile Express Cortex-A core tiles"
>  		depends on ARCH_VEXPRESS && CPU_CP15_MMU
> @@ -1084,6 +1100,8 @@ config DEBUG_UART_PHYS
>  	default 0x101f1000 if ARCH_VERSATILE
>  	default 0x101fb000 if DEBUG_NOMADIK_UART
>  	default 0x11006000 if DEBUG_MT6589_UART0
> +	default 0x11002000 if DEBUG_MT8127_UART0
> +	default 0x11009000 if DEBUG_MT8135_UART3

These lines are ordered by the address.

>  	default 0x16000000 if ARCH_INTEGRATOR
>  	default 0x18000300 if DEBUG_BCM_5301X
>  	default 0x1c090000 if DEBUG_VEXPRESS_UART0_RS1
> @@ -1147,6 +1165,8 @@ config DEBUG_UART_VIRT
>  	default 0xf0201000 if DEBUG_BCM2835
>  	default 0xf1000300 if DEBUG_BCM_5301X
>  	default 0xf1006000 if DEBUG_MT6589_UART0
> +	default 0xf1002000 if DEBUG_MT8127_UART0
> +	default 0xf1009000 if DEBUG_MT8135_UART3

Same here.
Apart from that the patches look fine to me.

Cheers,
Matthias

>  	default 0xf11f1000 if ARCH_VERSATILE
>  	default 0xf1600000 if ARCH_INTEGRATOR
>  	default 0xf1c28000 if DEBUG_SUNXI_UART0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/