linux-kernel - Re: [PATCH v2 1/1] staging: rtl8192u: Move ieee80211_crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Sep 2014 18:04:16 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	"Ragnar B. Johannsson" <ragnar@....is>
Cc:	gregkh@...uxfoundation.org, gdonald@...il.com,
	himangi774@...il.com, joe@...ches.com, joelpelaez@...il.com,
	arnd@...db.de, jmmahler@...il.com, peter.p.waskiewicz.jr@...el.com,
	antoine@...weitzer-chaput.fr, anarey@...il.com, c@...io,
	rickard_strandqvist@...ctrumdigital.se, teobaluta@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] staging: rtl8192u: Move ieee80211_crypto_*
 declarations to ieee80211/ieee80211.h

On Thu, Sep 18, 2014 at 02:33:25PM +0000, Ragnar B. Johannsson wrote:
> Move ieee80211_crypto*_init and _exit prototype declarations from r8192U_core.c to ieee80211/ieee80211.h. This fixes the following sparse warnings:
> 
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c:203:12: warning: symbol 'ieee80211_crypto_init' was not declared. Should it be static?
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c:223:13: warning: symbol 'ieee80211_crypto_deinit' was not declared. Should it be static?
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:764:12: warning: symbol 'ieee80211_crypto_tkip_init' was not declared. Should it be static?
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:769:13: warning: symbol 'ieee80211_crypto_tkip_exit' was not declared. Should it be static?
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c:467:12: warning: symbol 'ieee80211_crypto_ccmp_init' was not declared. Should it be static?
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c:472:13: warning: symbol 'ieee80211_crypto_ccmp_exit' was not declared. Should it be static?
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c:281:12: warning: symbol 'ieee80211_crypto_wep_init' was not declared. Should it be static?
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c:286:13: warning: symbol 'ieee80211_crypto_wep_exit' was not declared. Should it be static?
> 
> Signed-off-by: Ragnar B. Johannsson <ragnar@....is>
> ---
> Changes in v2: Remove extern, as suggested by Dan Carpenter.

Fantastic.  Thanks!

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/