linux-kernel - Re: [PATCH] cgroup: fix unbalanced locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpV0LykCy1GpZUmaAse_niNPnabLKTkW=LdoBjKhqkyx0Q@mail.gmail.com>
Date:	Thu, 18 Sep 2014 09:14:37 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Zefan Li <lizefan@...wei.com>
Cc:	Tejun Heo <tj@...nel.org>, Cgroups <cgroups@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cgroup: fix unbalanced locking

On Thu, Sep 18, 2014 at 2:28 AM, Zefan Li <lizefan@...wei.com> wrote:
> cgroup_pidlist_start() holds cgrp->pidlist_mutex and then calls
> pidlist_array_load(), and cgroup_pidlist_stop() releases the mutex.
>
> It is wrong that we release the mutex in the failure path in
> pidlist_array_load(), because cgroup_pidlist_stop() will be called
> no matter if cgroup_pidlist_start() returns errno or not.
>

I found same thing yesterday and tried to analysis if this could
be the cause of the the NULL ptr def bug I saw, it seems not.

Anyway, this fix is definitely correct,

Acked-by: Cong Wang <xiyou.wangcong@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/