linux-kernel - Re: [PATCH 1/2] perf session: Add option to copy events when queueing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <541B3ECD.8000706@gmail.com>
Date:	Thu, 18 Sep 2014 14:21:33 -0600
From:	David Ahern <dsahern@...il.com>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Alexander Yarygin <yarygin@...ux.vnet.ibm.com>
CC:	linux-kernel@...r.kernel.org,
	Christian Borntraeger <borntraeger@...ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>, Jiri Olsa <jolsa@...hat.com>,
	Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung.kim@....com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 1/2] perf session: Add option to copy events when queueing

On 9/18/14, 12:53 PM, Arnaldo Carvalho de Melo wrote:
> If nobody objects I'll merge this patch, as it fixes problems, but I
> wonder if the best wouldn't be simply not calling
> perf_evlist__mmap_consume() till the last event there is in fact
> consumed... I.e. as we _really_ consume the events, we remove it from
> there.
>
> Instead of consuming the event at perf_tool->sample() time, we would
> do it at perf_tool->finished_round(), would that be feasible? Has anyone
> tried this?

Hmmm... haven't tried this.  Conceptually it should work - at least 
nothing comes to mind at the moment.


Patch looked ok to me: Reviewed-by: David Ahern <dsahern@...il.com>

Jiri should review based on his recent changes for ordered events.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/