linux-kernel - Re: [PATCH] pinctrl: qcom: use restart_notifier mechanism for ps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140918224904.GD3749@joshc.qualcomm.com>
Date:	Thu, 18 Sep 2014 17:49:04 -0500
From:	Josh Cartwright <joshc@...eaurora.org>
To:	Kumar Gala <galak@...eaurora.org>
Cc:	Josh Cartwright <joshc@...eaurora.org>,
	Bjorn Andersson <bjorn.andersson@...ymobile.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-arm-msm@...r.kernel.org,
	Pramod Gurav <pramod.gurav@...rtplayin.com>,
	Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH] pinctrl: qcom: use restart_notifier mechanism for ps_hold

On Thu, Sep 18, 2014 at 03:47:20PM -0700, Kumar Gala wrote:
> On Sep 18, 2014, at 3:32 PM, Josh Cartwright <joshc@...eaurora.org> wrote:
> 
> > By converting to the restart_notifier mechanism for restart, we allow
> > for other mechanisms, like the watchdog, to be used for restart in the
> > case where PS_HOLD has failed to reset the chip.
> > 
> > Choose priority 128, as according to documentation, this mechanism "is
> > sufficient to restart the entire system?.
> 
> Will we use a higher priority for watchdog?  or how would we fail over to watchdog?

The registered restart handlers are called in (descending) priority
order.  This driver registers as 128, but conceivably there could be
some super-board-specific restart mechanism that can register itself as
higher priority than this and it will be attempted first.

If PS_HOLD doesn't work, the lower priority restart handlers will
continue to be called, including the watchdog, which is registering with
the lowest priority (0).

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/