lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 19 Sep 2014 21:07:35 +0800
From:	Ming Lei <>
To:	Jens Axboe <>
Cc:	Christoph Hellwig <>,
	James Bottomley <>,
	Linux SCSI List <>,
	Linux Kernel Mailing List <>,
	Douglas Gilbert <>
Subject: Re: [PATCH] scsi-mq: fix hw queue hang caused by timeout

On Fri, Sep 19, 2014 at 1:03 AM, Jens Axboe <> wrote:
> On 2014-09-18 10:35, Christoph Hellwig wrote:
>> On Thu, Sep 18, 2014 at 11:59:10PM +0800, Ming Lei wrote:
>>> If there are two requests or more timed out, the dispatch queue
>>> is put into stopped state and never be recoverd, and there
>>> is no such problem in non-mq mode.
>>> This patch trys to recover the stopped queue when the queue
>>> becomes unbusy, then the following retries can move on.
>>> Basically this patch maintains same behavior for this situation
>>> with non-mq mode.
>> This looks somewhat similar to the issues that Doug reported, and I
>> remember
>> when he was last running into boot problems it was timeout related, too.
>> As far as the implementation is concerned I think the correct fix is
>> to clear the BLK_MQ_S_STOPPED queue flags in blk_mq_kick_requeue_list.
> Since that's the kick part of the requeue, auto-starting the queue for that
> makes a lot of sense. I say that's the way we go.

Yeah, that looks better.

But it doesn't work after the simple change, and I need to
investigate further.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists