linux-kernel - Re: [PATCH 3/3] cgroup: remove CGRP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140919133015.GB31015@mtj.dyndns.org>
Date:	Fri, 19 Sep 2014 09:30:15 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Zefan Li <lizefan@...wei.com>
Cc:	Cgroups <cgroups@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] cgroup: remove CGRP_RELEASABLE flag

On Fri, Sep 19, 2014 at 04:51:00PM +0800, Zefan Li wrote:
> We call put_css_set() after setting CGRP_RELEASABLE flag in
> cgroup_task_migrate(), but in other places we call it without setting
> the flag. I don't see the necessity of this flag.
> 
> Moreover once the flag is set, it will never be cleared, unless writing
> to the notify_on_release control file, so it can be quite confusing
> if we look at the output of debug.releasable.
> 
>   # mount -t cgroup -o debug xxx /cgroup
>   # mkdir /cgroup/child
>   # cat /cgroup/child/debug.releasable
>   0   <-- shows 0 though the cgroup is empty
>   # echo $$ > /cgroup/child/tasks
>   # cat /cgroup/child/debug.releasable
>   0
>   # echo $$ > /cgroup/tasks && echo $$ > /cgroup/child/tasks
>   # cat /proc/child/debug.releasable
>   1   <-- shows 1 though the cgroup is not empty
> 
> This patch removes the flag, and now debug.releasable shows if the
> cgroup is empty or not.
> 
> Signed-off-by: Zefan Li <lizefan@...wei.com>

Applied to cgroup/for-3.18.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/