linux-kernel - Re: [PATCH] blk-timeout: fix blk_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <541C39BB.8010804@kernel.dk>
Date:	Fri, 19 Sep 2014 08:12:11 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Ming Lei <ming.lei@...onical.com>, linux-kernel@...r.kernel.org,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] blk-timeout: fix blk_add_timer

On 09/19/2014 07:53 AM, Ming Lei wrote:
> Commit 8cb34819cdd5d(blk-mq: unshared timeout handler) introduces
> blk-mq's own timeout handler, and removes following line
> 
> 	blk_queue_rq_timed_out(q, blk_mq_rq_timed_out);
> 
> then cause blk_add_timer() to do nop in case of blk-mq.
> 
> This patch fixes the problem by bypassing the check for blk-mq.

Good catch, this explains something I ran into yesterday on a missing
timer. I had a hard time understanding your description here, I'll
reword it a little bit and apply. Thanks!

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/