lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Sep 2014 09:29:38 -0500 From: Dinh Nguyen <dinguyen@...nsource.altera.com> To: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com> CC: <paulz@...opsys.com>, <gregkh@...uxfoundation.org>, <balbi@...com>, <dinh.linux@...il.com>, <swarren@...dotorg.org>, <matthijs@...in.nl>, <r.baldyga@...sung.com>, <jg1.han@...sung.com>, <sachin.kamat@...aro.org>, <ben-linux@...ff.org>, <dianders@...omium.org>, <kever.yang@...k-chips.com>, <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCHv4 08/12] usb: dwc2: gadget: Do not fail probe if there isn't a clock node On 9/12/14, 11:28 AM, Bartlomiej Zolnierkiewicz wrote: > > [ added linux-kernel ML to cc: ] > > Hi, > > On Tuesday, August 26, 2014 11:19:59 AM dinguyen@...nsource.altera.com wrote: >> From: Dinh Nguyen <dinguyen@...nsource.altera.com> >> >> Since the dwc2 hcd driver is currently not looking for a clock node during >> init, we should not completely fail if there isn't a clock provided. >> Add a check for a valid clock before calling clock functions. > > This doesn't look correct at least for the case when we are really missing > the clock and USB_DWC2_PERIPHERAL=y (moreover it just looks wrong to access > gadget functionalities when clock is disabled). It seems that it would be > better to just disable gadget functionality on dwc2_gadget_init() failure > in hcd and not call gadget functions later from hcd if gadget functionality > is disabled. > Yes...this is correct. Will fix up in v5. Thanks, Dinh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists