lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Sep 2014 16:33:28 +0200 From: Matthias Brugger <matthias.bgg@...il.com> To: "Joe.C" <yingjoe.chen@...iatek.com> Cc: srv_hongzhou.yang@...iatek.com, Rob Herring <robh+dt@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, srv_heupstream <srv_heupstream@...iatek.com>, "=Sascha Hauer" <kernel@...gutronix.de>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Russell King <linux@....linux.org.uk>, Grant Likely <grant.likely@...aro.org>, Hongzhou Yang <hongzhou.yang@...iatek.com>, Catalin Marinas <catalin.marinas@....com>, Vladimir Murzin <vladimir.murzin@....com>, Ashwin Chaugule <ashwin.chaugule@...aro.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH 2/4] ARM: mediatek: Add Pinctrl/GPIO driver for mt8135. 2014-09-19 15:47 GMT+02:00 Joe.C <yingjoe.chen@...iatek.com>: > On Fri, 2014-09-19 at 19:48 +0800, srv_hongzhou.yang@...iatek.com wrote: >> + >> +static const struct pinmux_ops mt_pmx_ops = { >> + .get_functions_count = mt_pmx_get_funcs_cnt, >> + .get_function_name = mt_pmx_get_func_name, >> + .get_function_groups = mt_pmx_get_func_groups, >> + .enable = mt_pmx_enable, >> + .disable = mt_pmx_disable, >> + .gpio_set_direction = mt_pmx_gpio_set_direction, >> +}; >> + > > It seems pinmux_ops.disable is removed in commit commit > 2243a87d90b42eb38bc281957df3e57c712b5e56. So this will cause build > error. This should be fixed in next version. For this cases and in general it would be good to put in the patch set description against which tree/tag the patches are build. Thanks, Matthias > > ../drivers/pinctrl/mediatek/pinctrl-mtk-common.c:566:2: error: unknown > field 'disable' specified in initializer > ../drivers/pinctrl/mediatek/pinctrl-mtk-common.c:566:2: warning: > initialization from incompatible pointer type [enabled by default] > ../drivers/pinctrl/mediatek/pinctrl-mtk-common.c:566:2: warning: (near > initialization for 'mt_pmx_ops.gpio_request_enable') [enabled by > default] > > Joe.C > > -- motzblog.wordpress.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists