linux-kernel - Re: [PATCH 2/2] powerpc32: add support for csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF690C56D2.618CBADE-ONC1257D58.00535C2F-C1257D58.005426A0@transmode.se>
Date:	Fri, 19 Sep 2014 17:19:08 +0200
From:	Joakim Tjernlund <joakim.tjernlund@...nsmode.se>
To:	Christophe Leroy <christophe.leroy@....fr>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	Paul Mackerras <paulus@...ba.org>, scottwood@...escale.com
Subject: Re: [PATCH 2/2] powerpc32: add support for csum_add()

Christophe Leroy <christophe.leroy@....fr> wrote on 2014/09/19 15:57:56:
> Subject: [PATCH 2/2] powerpc32: add support for csum_add()
> 
> The C version of csum_add() as defined in include/net/checksum.h gives 
the
> following assembly:
>        0:       7c 04 1a 14     add     r0,r4,r3
>        4:       7c 64 00 10     subfc   r3,r4,r0
>        8:       7c 63 19 10     subfe   r3,r3,r3
>        c:       7c 63 00 50     subf    r3,r3,r0
> 
> include/net/checksum.h also offers the possibility to define an arch 
specific
> function.
> This patch provides a ppc32 specific csum_add() inline function.
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@....fr>
> 
> ---

Ouch, this is still so. Back in 2010 I reported this to gcc:
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43892

Anyway, 
        Acked-by: Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/