linux-kernel - Re: [PATCH 5/7] signal: Silence nested-externs warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1411141042.2513.3.camel@jtkirshe-mobl>
Date:	Fri, 19 Sep 2014 08:37:22 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Richard Weinberger <richard@....at>
Cc:	sparse@...isli.org, Mark Rustad <mark.d.rustad@...el.com>,
	linux-sparse@...r.kernel.org, linux-kernel@...r.kernel.org,
	Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Brian Norris <computersforpeace@...il.com>
Subject: Re: [PATCH 5/7] signal: Silence nested-externs warnings

On Fri, 2014-09-19 at 17:35 +0200, Richard Weinberger wrote:
> Am 19.09.2014 17:29, schrieb Jeff Kirsher:
> > From: Mark Rustad <mark.d.rustad@...el.com>
> > 
> > Silence nested-externs warnings for these, as these nested
> > externs are truly wanted.
> > 
> > CC: Oleg Nesterov <oleg@...hat.com>
> > CC: Andrew Morton <akpm@...ux-foundation.org>
> > CC: Geert Uytterhoeven <geert@...ux-m68k.org>
> > CC: Richard Weinberger <richard@....at>
> > CC: Brian Norris <computersforpeace@...il.com>
> > Signed-off-by: Mark Rustad <mark.d.rustad@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> > ---
> >  include/linux/signal.h | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/include/linux/signal.h b/include/linux/signal.h
> > index 750196f..e68ae6b 100644
> > --- a/include/linux/signal.h
> > +++ b/include/linux/signal.h
> > @@ -67,7 +67,9 @@ static inline int sigismember(sigset_t *set, int _sig)
> >  
> >  static inline int sigisemptyset(sigset_t *set)
> >  {
> > +	DIAG_PUSH DIAG_IGNORE(nested-externs)
> 
> Do we really want to clutter the source with such tags?
> Does this even build? i.e. how does gcc know to ignore that?
> 
> rw@...ael:~/linux (ubi-wlcrash $)> git grep DIAG_PUSH | wc -l
> 0
> 
> Thanks,
> //richard

See patch 1 of the series.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)