lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 19 Sep 2014 10:01:28 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Liu Hua <sdu.liu@...wei.com>, shuah.khan@...com
CC:	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	peifeiyue@...wei.com, Jiri Kosina <trivial@...nel.org>
Subject: Re: [PATCH] Documentation: correct parameter error for dma_mapping_error

On 09/17/14 21:15, Liu Hua wrote:
> dma_mapping_error takes two parameters, but some of examples
> in Documentation/DMA-API-HOWTO.txt just takes one. So correct
> it.
> 
> Signed-off-by: Liu Hua <sdu.liu@...wei.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

Jiri, please apply this patch.  Thanks.

> ---
>  Documentation/DMA-API-HOWTO.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/DMA-API-HOWTO.txt b/Documentation/DMA-API-HOWTO.txt
> index dcbbe36..0f7afb2 100644
> --- a/Documentation/DMA-API-HOWTO.txt
> +++ b/Documentation/DMA-API-HOWTO.txt
> @@ -531,7 +531,7 @@ To map a single region, you do:
>  	size_t size = buffer->len;
>  
>  	dma_handle = dma_map_single(dev, addr, size, direction);
> -	if (dma_mapping_error(dma_handle)) {
> +	if (dma_mapping_error(dev, dma_handle)) {
>  		/*
>  		 * reduce current DMA mapping usage,
>  		 * delay and try again later or
> @@ -588,7 +588,7 @@ Specifically:
>  	size_t size = buffer->len;
>  
>  	dma_handle = dma_map_page(dev, page, offset, size, direction);
> -	if (dma_mapping_error(dma_handle)) {
> +	if (dma_mapping_error(dev, dma_handle)) {
>  		/*
>  		 * reduce current DMA mapping usage,
>  		 * delay and try again later or
> @@ -689,7 +689,7 @@ to use the dma_sync_*() interfaces.
>  		dma_addr_t mapping;
>  
>  		mapping = dma_map_single(cp->dev, buffer, len, DMA_FROM_DEVICE);
> -		if (dma_mapping_error(dma_handle)) {
> +		if (dma_mapping_error(cp->dev, dma_handle)) {
>  			/*
>  			 * reduce current DMA mapping usage,
>  			 * delay and try again later or
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists