lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Sep 2014 10:27:32 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Jisheng Zhang <jszhang@...vell.com> Cc: wim@...ana.be, linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 1/2] watchdog: dw_wdt: restart the counter immediately after enabling WDT On Fri, Sep 19, 2014 at 02:29:58PM +0800, Jisheng Zhang wrote: > The TOP_INIT may be zero, so the timeout period may be very short after What is TOP_INIT ? > initialization is done, thus the system may be reset soon after enabling. > We fix this problem by restarting the counter immediately after enabling > WDT. > > Signed-off-by: Jisheng Zhang <jszhang@...vell.com> > --- > drivers/watchdog/dw_wdt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c > index 9f21029..ad0619d 100644 > --- a/drivers/watchdog/dw_wdt.c > +++ b/drivers/watchdog/dw_wdt.c > @@ -146,6 +146,7 @@ static int dw_wdt_open(struct inode *inode, struct file *filp) > dw_wdt_set_top(DW_WDT_MAX_TOP); This sets the timeout to the maximum, so I guess there must be some other event/register (TOP_INIT ?) which can be zero. > writel(WDOG_CONTROL_REG_WDT_EN_MASK, > dw_wdt.regs + WDOG_CONTROL_REG_OFFSET); What guarantees that the reset didn't already happen by the time the keepalive call is executed ? Does this change fix the problem, or does it just make it more unlikely to be seen ? Thanks, Guenter > + dw_wdt_keepalive(); > } > > dw_wdt_set_next_heartbeat(); > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists