linux-kernel - Re: [PATCH] blk-mq: auto-start hw queue in requeue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <541C6FD7.7090201@kernel.dk>
Date:	Fri, 19 Sep 2014 12:03:03 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Christoph Hellwig <hch@....de>
CC:	Ming Lei <ming.lei@...onical.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blk-mq: auto-start hw queue in requeue

On 09/19/2014 11:54 AM, Christoph Hellwig wrote:
> On Fri, Sep 19, 2014 at 11:52:59AM -0600, Jens Axboe wrote:
>> I agree. I think Ming wanted to avoid an unnecessary bitflip if
>> possible, but the fix is more convoluted than I would like.
> 
> If the requeue from irq context ever ends up in the fast path we
> have much worse problems..

Oh yes certainly, my point was purely that I think this is why Mings fix
ended up being more involved than it need be.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/