linux-kernel - Re: [PATCH v3 1/2] regulator: st-pwm: get voltage and duty table from dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Vm-XgNvfQjtaXML3_1ROoir5Kv2fosSr94jkcG6K3P6A@mail.gmail.com>
Date:	Fri, 19 Sep 2014 13:22:54 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	Chris Zhong <zyw@...k-chips.com>
Cc:	Heiko Stübner <heiko@...ech.de>,
	linux-rockchip@...ts.infradead.org,
	Lee Jones <lee.jones@...aro.org>,
	"broonie@...nel.org" <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] regulator: st-pwm: get voltage and duty table from dts

Chris,

On Fri, Sep 19, 2014 at 1:02 AM, Chris Zhong <zyw@...k-chips.com> wrote:
> Get voltage & duty table from device tree might be better, other platforms can also use this
> driver without any modify.
>
> Signed-off-by: Chris Zhong <zyw@...k-chips.com>
>
> ---
>
> Changes in v3:
> Adviced by Doug Anderson
> - Make Kconfig & Makefile alphabetical
> - remove pwm_reg_period from pwm_regulator_data
> - modify the calculation in pwm_regulator_set_voltage_sel
> - add length validity check
>
> Changes in v2:
> Adviced by Lee Jones
> - rename the file
> - remove all the prefix st_
> - add depend on PWM in Kconfig
>
>  drivers/regulator/Kconfig         |   13 +--
>  drivers/regulator/Makefile        |    2 +-
>  drivers/regulator/pwm-regulator.c |  197 +++++++++++++++++++++++++++++++++++++
>  drivers/regulator/st-pwm.c        |  190 -----------------------------------
>  4 files changed, 205 insertions(+), 197 deletions(-)
>  create mode 100644 drivers/regulator/pwm-regulator.c
>  delete mode 100644 drivers/regulator/st-pwm.c
>
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index fb32bab..320751a 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -449,6 +449,13 @@ config REGULATOR_PFUZE100
>           Say y here to support the regulators found on the Freescale
>           PFUZE100/PFUZE200 PMIC.
>
> +config REGULATOR_PWM
> +       tristate "PWM voltage regulator"
> +       depends on PWM
> +       help
> +         This driver supports PWM controlled voltage regulators. Config PWM
> +         duty can increasing or decreasing the voltage.

Slightly more proper English:
        This driver supports PWM controlled voltage regulators. PWM
        duty cycle can increase or decrease the voltage.


> +static struct regulator_desc pwm_regulator_desc = {
> +       .name           = "pwm-regulator",
> +       .ops            = &pwm_regulator_voltage_ops,
> +       .type           = REGULATOR_VOLTAGE,
> +       .owner          = THIS_MODULE,
> +       .supply_name    = "pwm",
> +};

nit: the pwm_regulator_desc can now be "const".


Neither of those is huge.  If you get no other feedback, Mark could
maybe give advice on whether you should spin your series or whether
he'd like to fix them when he applies.

Reviewed-by: Doug Anderson <dianders@...omium.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/