lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Sep 2014 22:59:13 +0000 From: Anish Bhatt <anish@...lsio.com> To: Randy Dunlap <rdunlap@...radead.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, David Miller <davem@...emloft.net> CC: LKML <linux-kernel@...r.kernel.org>, James Bottomley <jbottomley@...allels.com> Subject: RE: [PATCH] scsi: fix SCSI_BNX2X_FCOE dependencies and build errors Leaves only 1 warning still reproduceable : (LIBFCOE && TCM_QLA2XXX) selects LIBFC which has unmet direct dependencies (SCSI_LOWLEVEL && SCSI && SCSI_FC_ATTRS), so maybe that needs a fix too ? All the other fcoe/scsi menu entries behave as expected. Tested-by: Anish Bhatt <anish@...lsio.com> ________________________________________ From: Randy Dunlap [rdunlap@...radead.org] Sent: Friday, September 19, 2014 3:38 PM To: netdev@...r.kernel.org; David Miller Cc: LKML; Anish Bhatt; James Bottomley Subject: [PATCH] scsi: fix SCSI_BNX2X_FCOE dependencies and build errors From: Randy Dunlap <rdunlap@...radead.org> Don't enable NETDEVICES when NET is not enabled. That causes build warnings and errors. warning: (SCSI_CXGB3_ISCSI && SCSI_CXGB4_ISCSI && SCSI_BNX2X_FCOE) selects NETDEVICES which has unmet direct dependencies (NET) warning: (SCSI_CXGB3_ISCSI && SCSI_CXGB4_ISCSI && SCSI_BNX2_ISCSI && SCSI_BNX2X_FCOE) selects ETHERNET which has unmet direct dependencies (NETDEVICES && NET) warning: (SCSI_BNX2X_FCOE && LIBFCOE && TCM_QLA2XXX) selects LIBFC which has unmet direct dependencies (SCSI_LOWLEVEL && SCSI && SCSI_FC_ATTRS) ../drivers/net/ethernet/cisco/enic/enic_main.c: In function 'enic_rq_indicate_buf': ../drivers/net/ethernet/cisco/enic/enic_main.c:1077:3: error: implicit declaration of function 'skb_mark_napi_id' [-Werror=implicit-function-declaration] ../drivers/net/ethernet/cisco/enic/enic_main.c:1078:3: error: implicit declaration of function 'enic_poll_busy_polling' [-Werror=implicit-function-declaration] Signed-off-by: Randy Dunlap <rdunlap@...radead.org> --- drivers/scsi/bnx2fc/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-next-20140918.orig/drivers/scsi/bnx2fc/Kconfig +++ linux-next-20140918/drivers/scsi/bnx2fc/Kconfig @@ -1,7 +1,8 @@ config SCSI_BNX2X_FCOE tristate "QLogic NetXtreme II FCoE support" - depends on PCI + depends on PCI && NET depends on (IPV6 || IPV6=n) + depends on SCSI_FC_ATTRS select NETDEVICES select ETHERNET select NET_VENDOR_BROADCOM -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists