lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Sep 2014 13:18:53 +0800 From: Jiang Liu <jiang.liu@...ux.intel.com> To: Joerg Roedel <joro@...tes.org>, David Woodhouse <dwmw2@...radead.org>, Yinghai Lu <yinghai@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, Dan Williams <dan.j.williams@...el.com>, Vinod Koul <vinod.koul@...el.com>, "Rafael J . Wysocki" <rafael.j.wysocki@...el.com> Cc: Jiang Liu <jiang.liu@...ux.intel.com>, Ashok Raj <ashok.raj@...el.com>, Yijing Wang <wangyijing@...wei.com>, Tony Luck <tony.luck@...el.com>, iommu@...ts.linux-foundation.org, linux-pci@...r.kernel.org, linux-hotplug@...r.kernel.org, linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org Subject: [Patch Part3 V6 6/8] iommu/vt-d: Enhance error recovery in function intel_enable_irq_remapping() Enhance error recovery in function intel_enable_irq_remapping() by tearing down all created data structures. Signed-off-by: Jiang Liu <jiang.liu@...ux.intel.com> Reviewed-by: Yijing Wang <wangyijing@...wei.com> --- drivers/iommu/intel_irq_remapping.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c index 1edbbed8c6bc..ddf98a8782a2 100644 --- a/drivers/iommu/intel_irq_remapping.c +++ b/drivers/iommu/intel_irq_remapping.c @@ -701,9 +701,11 @@ static int __init intel_enable_irq_remapping(void) return eim ? IRQ_REMAP_X2APIC_MODE : IRQ_REMAP_XAPIC_MODE; error: - /* - * handle error condition gracefully here! - */ + for_each_iommu(iommu, drhd) + if (ecap_ir_support(iommu->ecap)) { + iommu_disable_irq_remapping(iommu); + intel_teardown_irq_remapping(iommu); + } if (x2apic_present) pr_warn("Failed to enable irq remapping. You are vulnerable to irq-injection attacks.\n"); -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists