lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Sep 2014 20:03:09 -0400 From: Rob Clark <robdclark@...il.com> To: Mark yao <mark.yao@...k-chips.com> Cc: Heiko Stübner <heiko@...ech.de>, Boris BREZILLON <boris.brezillon@...e-electrons.com>, David Airlie <airlied@...il.com>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Randy Dunlap <rdunlap@...radead.org>, Grant Likely <grant.likely@...aro.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, John Stultz <john.stultz@...aro.org>, Rom Lemarchand <romlem@...gle.com>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, linux-doc@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, linux-api@...r.kernel.org, linux-rockchip@...ts.infradead.org, dianders@...omium.org, Stéphane Marchesin <marcheu@...omium.org>, dbehr@...omium.org, Olof Johansson <olof@...om.net>, Daniel Kurtz <djkurtz@...omium.org>, Jianqun Xu <xjq@...k-chips.com>, kfx@...k-chips.com, jeff chen <cym@...k-chips.com>, Eddie Cai <cf@...k-chips.com>, Chris Zhong <zyw@...k-chips.com>, xxm@...k-chips.com, Tao Huang <huangtao@...k-chips.com>, Kever Yang <kever.yang@...k-chips.com>, yxj@...k-chips.com, wxt@...k-chips.com, xw@...k-chips.com Subject: Re: [PATCH v3 1/5] drm/rockchip: Add basic drm driver On Fri, Sep 19, 2014 at 1:47 AM, Mark yao <mark.yao@...k-chips.com> wrote: > diff --git a/include/uapi/drm/rockchip_drm.h b/include/uapi/drm/rockchip_drm.h > new file mode 100644 > index 0000000..8f8e60e > --- /dev/null > +++ b/include/uapi/drm/rockchip_drm.h > @@ -0,0 +1,97 @@ > +/* > + * > + * Copyright (c) Fuzhou Rockchip Electronics Co.Ltd > + * Authors: > + * Mark Yao <yzq@...k-chips.com> > + * > + * base on exynos_drm.h > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the License, or (at your > + * option) any later version. > + */ > + > +#ifndef _UAPI_ROCKCHIP_DRM_H > +#define _UAPI_ROCKCHIP_DRM_H > + > +#include <drm/drm.h> > + > +/** > + * User-desired buffer creation information structure. > + * > + * @size: user-desired memory allocation size. > + * @flags: user request for setting memory type or cache attributes. > + * @handle: returned a handle to created gem object. > + * - this handle will be set by gem module of kernel side. > + */ > +struct drm_rockchip_gem_create { > + uint64_t size; > + uint32_t flags; > + uint32_t handle; > +}; > + > +/** > + * A structure for getting buffer offset. > + * > + * @handle: a pointer to gem object created. > + * @pad: just padding to be 64-bit aligned. > + * @offset: relatived offset value of the memory region allocated. > + * - this value should be set by user. > + */ > +struct drm_rockchip_gem_map_off { > + uint32_t handle; > + uint32_t pad; > + uint64_t offset; > +}; > + > +/** > + * A structure for mapping buffer. > + * > + * @handle: a handle to gem object created. > + * @pad: just padding to be 64-bit aligned. > + * @size: memory size to be mapped. > + * @mapped: having user virtual address mmaped. > + * - this variable would be filled by rockchip gem module > + * of kernel side with user virtual address which is allocated > + * by do_mmap(). > + */ > +struct drm_rockchip_gem_mmap { > + uint32_t handle; > + uint32_t pad; > + uint64_t size; > + uint64_t mapped; > +}; Could we do without the mmap ioctl? It has been a source of problems in other drivers, and the ioctl to get mmap offset, plus normal mmap() on drm device file should be sufficient BR, -R > +/** > + * A structure to gem information. > + * > + * @handle: a handle to gem object created. > + * @flags: flag value including memory type and cache attribute and > + * this value would be set by driver. > + * @size: size to memory region allocated by gem and this size would > + * be set by driver. > + */ > +struct drm_rockchip_gem_info { > + uint32_t handle; > + uint32_t flags; > + uint64_t size; > +}; > + > +#define DRM_ROCKCHIP_GEM_CREATE 0x00 > +#define DRM_ROCKCHIP_GEM_MAP_OFFSET 0x01 > +#define DRM_ROCKCHIP_GEM_MMAP 0x02 > +#define DRM_ROCKCHIP_GEM_GET 0x04 > + > +#define DRM_IOCTL_ROCKCHIP_GEM_CREATE DRM_IOWR(DRM_COMMAND_BASE + \ > + DRM_ROCKCHIP_GEM_CREATE, struct drm_rockchip_gem_create) > + > +#define DRM_IOCTL_ROCKCHIP_GEM_MAP_OFFSET DRM_IOWR(DRM_COMMAND_BASE + \ > + DRM_ROCKCHIP_GEM_MAP_OFFSET, struct drm_rockchip_gem_map_off) > + > +#define DRM_IOCTL_ROCKCHIP_GEM_MMAP DRM_IOWR(DRM_COMMAND_BASE + \ > + DRM_ROCKCHIP_GEM_MMAP, struct drm_rockchip_gem_mmap) > + > +#define DRM_IOCTL_ROCKCHIP_GEM_GET DRM_IOWR(DRM_COMMAND_BASE + \ > + DRM_ROCKCHIP_GEM_GET, struct drm_rockchip_gem_info) > +#endif /* _UAPI_ROCKCHIP_DRM_H */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists