lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 20 Sep 2014 13:12:31 -0400 From: Tejun Heo <tj@...nel.org> To: Zefan Li <lizefan@...wei.com> Cc: Cgroups <cgroups@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] cgroup: remove redundant variable in cgroup_mount() Hello, Li. On Sat, Sep 20, 2014 at 02:49:10PM +0800, Zefan Li wrote: > Both pinned_sb and new_sb indicate if a new superblock is needed, > so we can just remove new_sb. > > Note now we must check if kernfs_tryget_sb() returns NULL, because > when it returns NULL, kernfs_mount() may still re-use an existing > superblock, which is just allocated by another concurent mount. > > Suggested-by: Tejun Heo <tj@...nel.org> > Signed-off-by: Zefan Li <lizefan@...wei.com> Ah, this is so much better. Thanks for doing this. Applied to cgroup/for-3.18. > --- > > Hi Tejun, > > I think you wanted to see the @new_sb argument removed from kernfs_mount(), > but it's also used in debugfs and we can't use kernfs_tryget_sb() to > replace the new_sb check. Bummer, someday. :) Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists