linux-kernel - Re: [PATCH] staging: wlan-ng: remove unused 'result' var

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140920183509.GA4515@computer.home.gateway>
Date:	Sat, 20 Sep 2014 19:35:09 +0100
From:	Grzegorz Swirski <grzegorz@...rski.name>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	gregkh@...uxfoundation.org, josh@...htriplett.org,
	stankus.modestas@...il.com, vitaly.osipov@...il.com,
	Johannes.Stadlinger@....de, himangi774@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: remove unused 'result' var

> you have not mentioned any commit log

Sorry. Patch against linux-next, commit
d7cf2b3139909a354a71e2885c942e21a60ea062

> > @@ -734,11 +732,10 @@ static int prism2mib_priv(struct mibrec *mib,
> >  				wpa.datalen = cpu_to_le16(pstr->len);
> >  				memcpy(wpa.data, pstr->data, pstr->len);
> >  
> > -				result =
> > -				    hfa384x_drvr_setconfig(hw,
> > -						   HFA384x_RID_CNFWPADATA,
> > -						   (u8 *) &wpa,
> > -						   sizeof(wpa));
> > +				hfa384x_drvr_setconfig(hw,
> > +						       HFA384x_RID_CNFWPADATA,
> > +						       (u8 *) &wpa,
> if you check your patch with --strict option then you will see one warning here.

There are many styling offences in this file. I didn't want to include
unrelated changes in one patch.

Grzegorz Swirski.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/