lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 21 Sep 2014 02:08:53 +0200 From: "Rafael J. Wysocki" <rjw@...ysocki.net> To: Amit Pundir <amit.pundir@...aro.org> Cc: linux-kernel@...r.kernel.org, Todd Poynor <toddpoynor@...gle.com>, Pavel Machek <pavel@....cz>, Thomas Gleixner <tglx@...utronix.de>, Len Brown <len.brown@...el.com>, linux-pm@...r.kernel.org, Android Kernel Team <kernel-team@...roid.com> Subject: Re: [PATCH v2] PM: Print pending wakeup IRQ preventing suspend On Friday, September 19, 2014 04:52:35 AM Amit Pundir wrote: > From: Todd Poynor <toddpoynor@...gle.com> > > Currently when a pending wakeup irq stops suspend, it can be difficult > to determine why suspend was prevented and which IRQ was actually > responsible. In order to help debug such situation, this patch prints the > IRQ number and action name of that pending wakeup irq. > > Cc: Pavel Machek <pavel@....cz> > Cc: Thomas Gleixner <tglx@...utronix.de> > Cc: Rafael J. Wysocki <rjw@...ysocki.net> > Cc: Len Brown <len.brown@...el.com> > Cc: linux-pm@...r.kernel.org > Cc: Android Kernel Team <kernel-team@...roid.com> > Acked-by: Pavel Machek <pavel@....cz> > Signed-off-by: Todd Poynor <toddpoynor@...gle.com> > [Amit Pundir: Reworded the commit message] > Signed-off-by: Amit Pundir <amit.pundir@...aro.org> > --- > Resending this patch assuming that it might have got lost in between merge > window rush last time and now people might have some time to look at it. > > kernel/irq/pm.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c > index abcd6ca..c2bc8d9 100644 > --- a/kernel/irq/pm.c > +++ b/kernel/irq/pm.c > @@ -109,8 +109,13 @@ int check_wakeup_irqs(void) check_wakeup_irqs() is going away in 3.18, please see linux-next (or the pm-genirq branch of linux-pm.git) for details. > * can abort suspend. > */ > if (irqd_is_wakeup_set(&desc->irq_data)) { > - if (desc->depth == 1 && desc->istate & IRQS_PENDING) > + if (desc->depth == 1 && desc->istate & IRQS_PENDING) { > + pr_info("Wakeup IRQ %d %s pending, suspend aborted\n", > + irq, > + desc->action && desc->action->name ? > + desc->action->name : ""); > return -EBUSY; > + } > continue; > } > /* > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists