linux-kernel - Re: [PATCH v2] i2c: i2c-tegra: Move clk_prepare/clk_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140920091622.GC1612@katana>
Date:	Sat, 20 Sep 2014 11:16:22 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Mikko Perttunen <cyndis@...si.fi>
Cc:	ldewangan@...dia.com, swarren@...dotorg.org,
	thierry.reding@...il.com, linux-i2c@...r.kernel.org,
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
	Mikko Perttunen <mperttunen@...dia.com>
Subject: Re: [PATCH v2] i2c: i2c-tegra: Move clk_prepare/clk_set_rate to probe

On Fri, Sep 05, 2014 at 12:28:18PM +0300, Mikko Perttunen wrote:
> From: Mikko Perttunen <mperttunen@...dia.com>
> 
> Currently the i2c-tegra bus driver prepares, enables
> and set_rates its clocks separately for each transfer.
> This causes locking problems when doing I2C transfers
> from clock notifiers; see
> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/268653.html
> 
> This patch moves clk_prepare/unprepare and clk_set_rate calls to
> the probe function, leaving only clk_enable/disable to be
> done on each transfer. This solves the locking issue.
> 
> Signed-off-by: Mikko Perttunen <mperttunen@...dia.com>

Applied to for-current, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)