lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 21 Sep 2014 18:42:43 +0200
From:	Oleg Nesterov <>
To:	Josh Triplett <>,
	Andrew Morton <>
Cc:	Richard Weinberger <>,
	Jeff Kirsher <>,,
	Mark Rustad <>,,,
	Geert Uytterhoeven <>,
	Brian Norris <>
Subject: [PATCH 0/1] signal: use BUILD_BUG() instead of

On 09/19, Josh Triplett wrote:
> On Fri, Sep 19, 2014 at 07:20:30PM +0200, Oleg Nesterov wrote:
> > But I have to admit it looks a bit ugly to me anyway.
> > Can't we simply kill _NSIG_WORDS_is_unsupported_size ?
> This looks quite preferable.  Can you post that with a commit message
> and signoff?

OK, please see 1/1.

> Also, the indentation on the second of the three BUILD_BUG
> calls has some spaces in it, which it shouldn't.

Yes, thanks, and it makes sense to also fix the indentation.

> With those fixed:
> Reviewed-by: Josh Triplett <>

Thanks. Could you ack it again?

I didn't preserve your ack because it seems that BUILD_BUG() and/or
BUILD_BUG_ON_MSG() deserve some cleanups... For example,

	if (0)

can't be compiled if __compiletime_error_fallback() falls back to a
negative-size array (see the changelog).

But I think that the code above must be correct by definition, see
the comment and the original changelog (1399ff86f2a2 "kernel.h: add
BUILD_BUG() macro"). So if this patch breaks the compilation with
some compiler/version we should update include/linux/compiler-xxx.h
or fix BUILD_BUG().


 include/linux/signal.h |   28 ++++++++++++----------------
 1 files changed, 12 insertions(+), 16 deletions(-)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists