linux-kernel - [PATCH 0/1] signal: use BUILD_BUG() instead of _NSIG_WORDS_is_unsupported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140921164243.GA16744@redhat.com>
Date:	Sun, 21 Sep 2014 18:42:43 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Josh Triplett <josh@...htriplett.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Richard Weinberger <richard@....at>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>, sparse@...isli.org,
	Mark Rustad <mark.d.rustad@...el.com>,
	linux-sparse@...r.kernel.org, linux-kernel@...r.kernel.org,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Brian Norris <computersforpeace@...il.com>
Subject: [PATCH 0/1] signal: use BUILD_BUG() instead of
	_NSIG_WORDS_is_unsupported_size()

On 09/19, Josh Triplett wrote:
>
> On Fri, Sep 19, 2014 at 07:20:30PM +0200, Oleg Nesterov wrote:
>
> > But I have to admit it looks a bit ugly to me anyway.
> > Can't we simply kill _NSIG_WORDS_is_unsupported_size ?
>
> This looks quite preferable.  Can you post that with a commit message
> and signoff?

OK, please see 1/1.

> Also, the indentation on the second of the three BUILD_BUG
> calls has some spaces in it, which it shouldn't.

Yes, thanks, and it makes sense to also fix the indentation.

> With those fixed:
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

Thanks. Could you ack it again?

I didn't preserve your ack because it seems that BUILD_BUG() and/or
BUILD_BUG_ON_MSG() deserve some cleanups... For example,

	if (0)
		BUILD_BUG();

can't be compiled if __compiletime_error_fallback() falls back to a
negative-size array (see the changelog).

But I think that the code above must be correct by definition, see
the comment and the original changelog (1399ff86f2a2 "kernel.h: add
BUILD_BUG() macro"). So if this patch breaks the compilation with
some compiler/version we should update include/linux/compiler-xxx.h
or fix BUILD_BUG().

Oleg.

 include/linux/signal.h |   28 ++++++++++++----------------
 1 files changed, 12 insertions(+), 16 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/