lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 21 Sep 2014 12:49:33 -0700
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	Mathias Krause <minipli@...glemail.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>
CC:	linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCHv2 2/3] x86, ptdump: Simplify page flag evaluation code

On 9/21/2014 8:26 AM, Mathias Krause wrote:
> -		if (pr & _PAGE_PCD)
> -			pt_dump_cont_printf(m, dmsg, "PCD ");
> -		else
> -			pt_dump_cont_printf(m, dmsg, "    ");
> +		pt_dump_cont(m, dmsg, "%-4s", pr & _PAGE_USER ? "USR" : "");

while you have some nice cleanups in your patch, I can't say I consider this an improvement.
Yes the C standard allows ? to be used like this
but no, I don't think it improves readability in general.
(I think for me the main exception is NULL pointer cases, but this is not one of these)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists