lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 21 Sep 2014 16:10:10 -0700 From: Brian Norris <computersforpeace@...il.com> To: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com> Cc: Florian Fainelli <f.fainelli@...il.com>, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, arnd@...db.de Subject: Re: [PATCH 1/2] bus: brcmstb_gisb: register the fault code hook Hi Thomas, On Sat, Sep 20, 2014 at 03:19:50PM +0200, Thomas Petazzoni wrote: > On Fri, 19 Sep 2014 12:44:39 -0700, Florian Fainelli wrote: > > > -void __init brcmstb_hook_fault_code(void) > > +static int __init brcmstb_hook_fault_code(void) > > { > > hook_fault_code(22, brcmstb_bus_error_handler, SIGBUS, 0, > > "imprecise external abort"); > > + return 0; > > } > > +arch_initcall(brcmstb_hook_fault_code) > > I don't have the entire context, but if your platform is part of > multi-platform, it means that regardless of which platform is actually > booting your system, you will register your fault hook. Is this the > intended behavior? > > Generally speaking, in a multiplatform context, many arch_initcall() > should have a conditional to check whether we're really on a platform > where the initcall is needed. Florian already sent v2, about which I already made a similar comment: https://lkml.org/lkml/2014/9/19/516 I believe Florian plans to move this into the platform device probe function instead. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists