linux-kernel - Re: [PATCH v3 1/5] sound: pci: ctxfi: added reference of snd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Sep 2014 09:04:53 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/5] sound: pci: ctxfi: added reference of snd_card

At Sun, 21 Sep 2014 21:33:37 +0530,
Sudip Mukherjee wrote:
> 
> added and initialized a pointer of snd_card in the struct hw to get a reference of
> the card in other functions

You need to explain why this change is needed.  The above text shows
what it'd do, but it doesn't give any explanation to convince why this
patch must be merged in.  In this case, it's a preliminary patch for
the changes to convert to dev_*() later.  It's the most important bit,
so don't forget it.


thanks,

Takashi

> 
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
>  sound/pci/ctxfi/ctatc.c      | 1 +
>  sound/pci/ctxfi/cthardware.h | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c
> index d92a08c..b21eda4 100644
> --- a/sound/pci/ctxfi/ctatc.c
> +++ b/sound/pci/ctxfi/ctatc.c
> @@ -1333,6 +1333,7 @@ static int atc_create_hw_devs(struct ct_atc *atc)
>  		pr_err("Failed to create hw obj!!!\n");
>  		return err;
>  	}
> +	hw->card = atc->card;
>  	atc->hw = hw;
>  
>  	/* Initialize card hardware. */
> diff --git a/sound/pci/ctxfi/cthardware.h b/sound/pci/ctxfi/cthardware.h
> index 5977e9a..940bbd0 100644
> --- a/sound/pci/ctxfi/cthardware.h
> +++ b/sound/pci/ctxfi/cthardware.h
> @@ -20,6 +20,7 @@
>  
>  #include <linux/types.h>
>  #include <linux/pci.h>
> +#include <sound/core.h>
>  
>  enum CHIPTYP {
>  	ATC20K1,
> @@ -184,6 +185,7 @@ struct hw {
>  	void *irq_callback_data;
>  
>  	struct pci_dev *pci;	/* the pci kernel structure of this card */
> +	struct snd_card *card; /* pointer to this card */
>  	int irq;
>  	unsigned long io_base;
>  	unsigned long mem_base;
> -- 
> 1.8.1.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/