lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 22 Sep 2014 15:46:16 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	taeung <treeze.taeung@...il.com>, linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org, acme@...nel.org
Subject: Re: [PATCH] modified error code when perf_session__new() fail

On Sun, Sep 21, 2014 at 12:44:55AM +0900, Namhyung Kim wrote:
> Hi Taeung,
> 
> Please CC perf maintainers when you send a perf patch.  I'm adding
> Arnaldo who maintains tooling part and Jiri who suggested this change.
> 
> 
> 2014-09-17 (수), 17:31 +0900, taeung:
> > Hi,
> > 
> > I modified error code for the requirement as below.
> > 
> > Author: taeung <treeze.taeung@...il.com>
> > Date:   Sat Sep 13 16:22:53 2014 +0900
> > 
> >       modified error code when perf_session__new() fail
> > 
> >          Because perf_session__new() could fail
> >          for more reasons than just ENOMEM,
> >          I modified error code(ENOMEM or EINVAL)
> >          into -1.
> 
> Hmm.. this seems you copied output of "git show" and send it via an
> email client.  I recommend you to use "git format-patch" and "git
> send-email" later.

yep, the patch is mangled.. also following doc might be useful:
Documentation/email-clients.txt

> 
> In addition, you forgot to add your Signed-off-by.
> 
> That being said I'm okay with the patch itself.  Jiri, this is what you
> wanted to do, right?

I have some vague memories about this.. any link to refresh my memory? ;-)
but right, the change seems ok

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists