lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 22 Sep 2014 16:09:53 +0200 (CEST) From: Jiri Kosina <jkosina@...e.cz> To: Benjamin Tissoires <benjamin.tissoires@...hat.com> cc: Ping Cheng <pinglinux@...il.com>, killertofu@...il.com, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] HID: wacom: fix timeout on probe for some wacoms On Tue, 16 Sep 2014, Benjamin Tissoires wrote: > Some Wacom tablets (at least the ISDv4 found in the Lenovo X230) timeout > during probe while retrieving the input reports. > The only time this information is valuable is during the feature_mapping > stage, so we can ask for it there and discard the generic input reports > retrieval. > > This gives a code path closer to the wacom.ko driver when it was in the > input subtree (not HID). > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com> > --- > > Hi Jiri, > > I run into this today while trying to improve the generic support of the ISDv4 > sensors (those found on laptops not sold by Wacom). > This is a regression from 3.16, in a sense that it can add up to 10 seconds to > the boot of the laptop. So IMO, this should go as a fix for 3.17-rc6. > > Unfortunately, c64d883476 changed the ABI and wacom_get_report() takes now one > less argument. I based my patch on top of the for-3.18/wacom branch, so in 3.17, > it will not compile. > I would personally be in favor of having c64d883476 and this one in 3.17, but > c64d883476 will also require some manual conflict resolution (cherry-pick is > complaining). > I can also resend it based on the v3.17-rc5 tag, but then we will have to update > the for-3.18/wacom when you will merge with Linus' tree. Hi Benjamin, c64d883476 is not really a rc7 material, so I'd not like to be cherry-picking it for this. My take on this would actually be to apply to for-3.18/wacom, mark it for stable, and then make sure that c64d883476 makes it to the first 3.17-stable. What do you think? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists