lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 21 Sep 2014 22:03:28 -0400
From:	nick <yocto6@...il.com>
To:	Peter Chen <Peter.Chen@...escale.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	"julia.lawall@...6.fr" <julia.lawall@...6.fr>,
	"oneukum@...e.de" <oneukum@...e.de>,
	"himangi774@...il.com" <himangi774@...il.com>,
	"stern@...land.harvard.edu" <stern@...land.harvard.edu>,
	"paul.gortmaker@...driver.com" <paul.gortmaker@...driver.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: FIX ME in  oxu210p-hcd.c



On 14-09-21 07:53 PM, Peter Chen wrote:
> 
>  
>> Subject: Re: FIX ME in oxu210p-hcd.c
>>
>>
>> I found a unfixed FIX ME in the file stated in my above message. I am
>> wondering what to set hcd->self.comtroller->dma_mask to as it's now been
>> defined to NULL and clearly even as a newbie this seem incorrect.
>> Regards Nick
> 
> Usually, it is set at its controller driver or pass through through device tree or
> platform data.
> 
> Peter
> 
Sorry Peter,
I apologize for asking for more help here but I will paste the function below and with my changes.
Please let me known if I am wrong and how to fix it as I new here.
Sorry for Wasting Your Time,
Nick 
static int oxu_reset(struct usb_hcd *hcd)
{
 	struct oxu_hcd *oxu = hcd_to_oxu(hcd);
 	int ret;

 	spin_lock_init(&oxu->mem_lock);
 	INIT_LIST_HEAD(&oxu->urb_list);
	oxu->urb_len = 0;

-	/* FIMXE */
+ 	hcd->self.controller->dma_mask = hcd->regs;

 	if (oxu->is_otg) {
		oxu->caps = hcd->regs + OXU_OTG_CAP_OFFSET;
		oxu->regs = hcd->regs + OXU_OTG_CAP_OFFSET + \
			HC_LENGTH(readl(&oxu->caps->hc_capbase));
 
		oxu->mem = hcd->regs + OXU_SPH_MEM;
	} else {
		oxu->caps = hcd->regs + OXU_SPH_CAP_OFFSET;
 		oxu->regs = hcd->regs + OXU_SPH_CAP_OFFSET + \
 			HC_LENGTH(readl(&oxu->caps->hc_capbase));

 		oxu->mem = hcd->regs + OXU_OTG_MEM;
	}

 	oxu->hcs_params = readl(&oxu->caps->hcs_params);
 	oxu->sbrn = 0x20;

	ret = oxu_hcd_init(hcd);
	if (ret)
 		return ret;
 
 	return 0;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists