linux-kernel - Re: [PATCH] mptfusion: enable no_write_same in scsi_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5420679D.3070406@canonical.com>
Date:	Mon, 22 Sep 2014 13:17:01 -0500
From:	Chris J Arges <chris.j.arges@...onical.com>
To:	Christoph Hellwig <hch@...radead.org>
CC:	linux-scsi@...t.kernel.org, bruce.lucas@...godb.com,
	Nagalakshmi Nandigama <nagalakshmi.nandigama@...gotech.com>,
	Praveen Krishnamoorthy <praveen.krishnamoorthy@...gotech.com>,
	Sreekanth Reddy <sreekanth.reddy@...gotech.com>,
	Abhijit Mahajan <abhijit.mahajan@...gotech.com>,
	MPT-FusionLinux.pdl@...gotech.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mptfusion: enable no_write_same in scsi_host_template



On 09/22/2014 01:02 PM, Christoph Hellwig wrote:
> On Mon, Sep 22, 2014 at 12:56:59PM -0500, Chris J Arges wrote:
>> When using a virtual SCSI disk in a VMWare VM if blkdev_issue_zeroout is used
>> data can be improperly zeroed out using the mptfusion driver. This patch
>> disables write_same for this driver which ensures that manual zeroing out
>> is used instead.
> 
> Does this affet real hardware or is it a VMware bug?  If it's just the
> latter we should simply blacklist VMware.
> 
I've only been able to reproduce this on VMWare. There is a pretty
straightforward reproducer in the BugLink if there is any interest in
verifying on hardware.

How would you recommending blacklisting only VMWare guests in this case?

Thanks,
--chris j arges
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/