linux-kernel - Re: [PATCH 0/7] Silence even more W=2 warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140922195737.GE4709@pd.tnic>
Date:	Mon, 22 Sep 2014 21:57:37 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	"Rustad, Mark D" <mark.d.rustad@...el.com>,
	"sparse@...isli.org" <sparse@...isli.org>,
	"linux-sparse@...r.kernel.org" <linux-sparse@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/7] Silence even more W=2 warnings

On Mon, Sep 22, 2014 at 12:44:17PM -0700, Jeff Kirsher wrote:
> Not sure you showed us, since that is how everyone has had to do to
> actual find W= builds useful.  Just because that is how we HAVE to do it
> now, does not make it the best way.  Here is a thought, we don't we fix
> the potential issues, so that W= builds do not generate over 100,000
> errors/warnings.
> 
> Mark did this approach because it would either spur the conversation
> that this is a good idea OR let's fix the root problem.  Instead it
> sounds like your response is "life sucks, get over it" and put your head
> back in the sand to ignore the problem.

Hey hey, relax a little - no need to get offensive all of a sudden.

Having to grep through a log file full of gcc warnings is a much better
thing to do IMNSVHO than adding code to the kernel just to shut up the
compiler. We had huge discussions even about something as silly as
uninitialized_var() which was supposed to shut up the compiler but ended
up actively causing bugs.

Now, you're arguing for adding obscure macros to shut up warnings which
are disabled in the first place because you don't want to grep through
log files.

If you can't see the absurdity of your proposal then maybe we should
agree to disagree and declare this back-and-forth for having run its
course. In any case, you get my NAK for it.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/