linux-kernel - Re: [PATCH] drm/vmwgfx: Fix drm.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140922195817.GV10640@betterave.cristau.org>
Date:	Mon, 22 Sep 2014 21:58:17 +0200
From:	Julien Cristau <jcristau@...ian.org>
To:	Josh Boyer <jwboyer@...oraproject.org>
Cc:	Thomas Hellstrom <thellstrom@...are.com>,
	David Airlie <airlied@...ux.ie>, dmarlin@...hat.com,
	Brian Paul <brianp@...are.com>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	DRI mailing list <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/vmwgfx: Fix drm.h include

On Tue, Sep 16, 2014 at 09:43:50 -0400, Josh Boyer wrote:

> On Fri, Sep 5, 2014 at 1:19 PM, Josh Boyer <jwboyer@...oraproject.org> wrote:
> > The userspace drm.h include doesn't prefix the drm directory.  This can lead
> > to compile failures as /usr/include/drm/ isn't in the standard gcc include
> > paths.  Fix it to be <drm/drm.h>, which matches the rest of the driver drm
> > header files that get installed into /usr/include/drm.
> >
> > Red Hat Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1138759
> >
> > Fixes: 1d7a5cbf8f74e
> > Reported-by: Jeffrey Bastian <jbastian@...hat.com>
> > Signed-off-by: Josh Boyer <jwboyer@...oraproject.org>
> 
> Ping?  Did this get queued anywhere?
> 
Any reason this doesn't just #include "drm.h"?  That should work whether
the drm headers are installed in /usr/include/drm/ or
/usr/include/libdrm/...

Cheers,
Julien, who doesn't have a /usr/include/drm/ either
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/