linux-kernel - Re: [PATCH] selinux: hooks: cleanup orphan keywords in audit log text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140922205939.GD26201@madcap2.tricolour.ca>
Date:	Mon, 22 Sep 2014 16:59:39 -0400
From:	Richard Guy Briggs <rgb@...hat.com>
To:	Paul Moore <pmoore@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, linux-audit@...hat.com,
	selinux@...ho.nsa.gov
Subject: Re: [PATCH] selinux: hooks: cleanup orphan keywords in audit log text

On 14/09/22, Paul Moore wrote:
> On Thursday, September 18, 2014 08:50:17 PM Richard Guy Briggs wrote:
> > Convert audit_log() call to WARN_ONCE().
> >
> > Rename "type=" to nlmsg_type=" to avoid confusion with the audit record
> > type.
> > 
> > Added "protocol=" to help track down which protocol (NETLINK_AUDIT?) was
> > used within the netlink protocol family.
> > 
> > Signed-off-by: Richard Guy Briggs <rgb@...hat.com>
> > ---
> >  security/selinux/hooks.c |    7 +++----
> >  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> I rewrote the patch subject line as it doesn't really make much sense given 
> the changes made by the patch, but other than that it looks fine to me.

Fair enough.  What's the new patch subject line?

> Applied.

Thanks.

> > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> > index 83d06db..28ec61c 100644
> > --- a/security/selinux/hooks.c
> > +++ b/security/selinux/hooks.c
> > @@ -4681,10 +4681,9 @@ static int selinux_nlmsg_perm(struct sock *sk, struct
> > sk_buff *skb) err = selinux_nlmsg_lookup(sksec->sclass, nlh->nlmsg_type,
> > &perm); if (err) {
> >  		if (err == -EINVAL) {
> > -			audit_log(current->audit_context, GFP_KERNEL, 
> AUDIT_SELINUX_ERR,
> > -				  "SELinux:  unrecognized netlink message"
> > -				  " type=%hu for sclass=%hu\n",
> > -				  nlh->nlmsg_type, sksec->sclass);
> > +			WARN_ONCE(1, "selinux_nlmsg_perm: unrecognized netlink 
> message:"
> > +				  " protocol=%hu nlmsg_type=%hu sclass=%hu\n",
> > +				  sk->sk_protocol, nlh->nlmsg_type, sksec->sclass);
> >  			if (!selinux_enforcing || security_get_allow_unknown())
> >  				err = 0;
> >  		}
> 
> paul moore

- RGB

--
Richard Guy Briggs <rbriggs@...hat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/