lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Sep 2014 00:38:32 +0200 From: Emil Goode <emilgoode@...il.com> To: Arend van Spriel <arend@...adcom.com> Cc: Brett Rudley <brudley@...adcom.com>, "Franky (Zhenhui) Lin" <frankyl@...adcom.com>, Hante Meuleman <meuleman@...adcom.com>, "John W. Linville" <linville@...driver.com>, Pieter-Paul Giesberts <pieterpg@...adcom.com>, Daniel Kim <dekim@...adcom.com>, linux-wireless@...r.kernel.org, brcm80211-dev-list@...adcom.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] brcmfmac: Fix off by one bug in brcmf_count_20mhz_channels() Hello Arend, Ok I will resend with your ack. Best regards, Emil On Mon, Sep 22, 2014 at 11:49:56AM +0200, Arend van Spriel wrote: > On 09/21/14 00:58, Emil Goode wrote: > >In the brcmf_count_20mhz_channels function we are looping through a list > >of channels received from firmware. Since the index of the first channel > >is 0 the condition leads to an off by one bug. This is causing us to hit > >the WARN_ON_ONCE(1) calls in the brcmu_d11n_decchspec function, which is > >how I discovered the bug. > > > >Introduced by: > >commit b48d891676f756d48b4d0ee131e4a7a5d43ca417 > >("brcmfmac: rework wiphy structure setup") > > My bad :-(. You can add: > > Acked-by: Arend van Spriel <arend@...adcom.com> > >Signed-off-by: Emil Goode<emilgoode@...il.com> > >--- > > drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c > >index 02fe706..93b5dd9 100644 > >--- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c > >+++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c > >@@ -4918,7 +4918,7 @@ static void brcmf_count_20mhz_channels(struct brcmf_cfg80211_info *cfg, > > struct brcmu_chan ch; > > int i; > > > >- for (i = 0; i<= total; i++) { > >+ for (i = 0; i< total; i++) { > > ch.chspec = (u16)le32_to_cpu(chlist->element[i]); > > cfg->d11inf.decchspec(&ch); > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists