lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Sep 2014 16:14:10 -0600 From: Alex Williamson <alex.williamson@...hat.com> To: Will Deacon <will.deacon@....com> Cc: Antonios Motakis <a.motakis@...tualopensystems.com>, "kvmarm@...ts.cs.columbia.edu" <kvmarm@...ts.cs.columbia.edu>, "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>, "tech@...tualopensystems.com" <tech@...tualopensystems.com>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "christoffer.dall@...aro.org" <christoffer.dall@...aro.org>, "kim.phillips@...escale.com" <kim.phillips@...escale.com>, "eric.auger@...aro.org" <eric.auger@...aro.org>, Marc Zyngier <Marc.Zyngier@....com>, Joerg Roedel <joro@...tes.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Shuah Khan <shuah.kh@...sung.com>, Thierry Reding <treding@...dia.com>, Alexey Kardashevskiy <aik@...abs.ru>, "Upinder Malhi (umalhi)" <umalhi@...co.com>, "moderated list:ARM SMMU DRIVER" <linux-arm-kernel@...ts.infradead.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCHv7 01/26] iommu/arm-smmu: change IOMMU_EXEC to IOMMU_NOEXEC On Tue, 2014-09-23 at 15:58 +0100, Will Deacon wrote: > Hi Antonios, > > On Tue, Sep 23, 2014 at 03:46:00PM +0100, Antonios Motakis wrote: > > Exposing the XN flag of the SMMU driver as IOMMU_NOEXEC instead of > > IOMMU_EXEC makes it enforceable, since for IOMMUs that don't support > > the XN flag pages will always be executable. > > > > Signed-off-by: Antonios Motakis <a.motakis@...tualopensystems.com> > > --- > > drivers/iommu/arm-smmu.c | 9 +++++---- > > include/linux/iommu.h | 2 +- > > 2 files changed, 6 insertions(+), 5 deletions(-) > > [...] > > > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > > index 20f9a52..e1a644c 100644 > > --- a/include/linux/iommu.h > > +++ b/include/linux/iommu.h > > @@ -27,7 +27,7 @@ > > #define IOMMU_READ (1 << 0) > > #define IOMMU_WRITE (1 << 1) > > #define IOMMU_CACHE (1 << 2) /* DMA cache coherency */ > > -#define IOMMU_EXEC (1 << 3) > > +#define IOMMU_NOEXEC (1 << 3) > > This hunk needs to be a separate patch merged by Joerg before I can take the > arm-smmu part (which looks fine). That separate hunk would be unbuildable since arm-smmu depends on the IOMMU_EXEC define. Patch 2/ is also in iommu code and gates patch 3/ in arm-smmu. The IOMMU-core changes are pretty trivial, so perhaps Joerg would be willing to ACK 1&2 and let Will include the first 3 patches through his tree. These first 3 patches should have been sent on their own since they're small an obvious so they don't get hung up on the reset of the series. Thanks, Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists