linux-kernel - Re: [PATCH 1/1] gpio: Fix ngpio in gpio-xilinx driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN+KFvYH_QcaUD5sgqYQTrTtWz7Sh+vV=f=X2D1NFgDBLHqgjA@mail.gmail.com>
Date:	Wed, 24 Sep 2014 00:48:36 +0200
From:	Gernot Vormayr <gvormayr@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	Michal Simek <michal.simek@...inx.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] gpio: Fix ngpio in gpio-xilinx driver

On Tue, Sep 23, 2014 at 5:38 PM, Linus Walleij <linus.walleij@...aro.org> wrote:
>
> The fact that the same code appears in two places tells us something
> is not quite right. Can you look into consolidating this (in a separate
> patch)?


Well, I already thought about that, but since the second time is for the
second part of a dual gpio, which has different device tree property names,
the only way of consolidating that I can think of right now would be to
create a function that takes the property names. If you think that's ok,
I can try to come up with something.

Cheers,
Gernot Vormayr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/