linux-kernel - Re: [PATCH 1/1] tools/perf: add missing include debug.h for arm/arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 23 Sep 2014 09:03:02 +0200
From:	Jean Pihet <jean.pihet@...aro.org>
To:	Fathi Boudra <fathi.boudra@...aro.org>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Masanari Iida <standby24x7@...il.com>,
	Will Deacon <will.deacon@....com>
Subject: Re: [PATCH 1/1] tools/perf: add missing include debug.h for arm/arm64

Hi Fathi,

On 23 September 2014 04:14, Fathi Boudra <fathi.boudra@...aro.org> wrote:
> Fix perf build failure on arm/arm64 architectures introduced by

The ARM fix is already in the tip tree at
http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=29a3ce31c38c8f73f4e076b7ffc0876b4f5dd6c3.

Can you refresh the patch for ARM64 only?

FWIW: Acked-by: Jean Pihet <jean.pihet@...aro.org>

Thanks!

> commit 84f5d36f4 (move pr_* debug macros into debug object):
>
>  arch/arm/util/unwind-libunwind.c: In function 'libunwind__arch_reg_id':
>  arch/arm/util/unwind-libunwind.c:43:3: error: implicit declaration
>  of function 'pr_err' [-Werror=implicit-function-declaration]
>    pr_err("unwind: invalid reg id %d\n", regnum);
>    ^
>  arch/arm/util/unwind-libunwind.c:43:3: error: nested extern declaration
>  of 'pr_err' [-Werror=nested-externs]
>  cc1: all warnings being treated as errors
>  make[2]: *** [arch/arm/util/unwind-libunwind.o] Error 1
>  arch/arm/tests/dwarf-unwind.c: In function 'sample_ustack':
>  arch/arm/tests/dwarf-unwind.c:20:3: error: implicit declaration
>  of function 'pr_debug' [-Werror=implicit-function-declaration]
>    pr_debug("failed to allocate sample uregs data\n");
>    ^
>  arch/arm/tests/dwarf-unwind.c:20:3: error: nested extern declaration
>  of 'pr_debug' [-Werror=nested-externs]
>  cc1: all warnings being treated as errors
>  make[2]: *** [arch/arm/tests/dwarf-unwind.o] Error 1
>
> Signed-off-by: Fathi Boudra <fathi.boudra@...aro.org>
> ---
>  tools/perf/arch/arm/tests/dwarf-unwind.c      | 1 +
>  tools/perf/arch/arm/util/unwind-libunwind.c   | 1 +
>  tools/perf/arch/arm64/util/unwind-libunwind.c | 1 +
>  3 files changed, 3 insertions(+)
>
> diff --git a/tools/perf/arch/arm/tests/dwarf-unwind.c b/tools/perf/arch/arm/tests/dwarf-unwind.c
> index 9f870d2..62eff84 100644
> --- a/tools/perf/arch/arm/tests/dwarf-unwind.c
> +++ b/tools/perf/arch/arm/tests/dwarf-unwind.c
> @@ -3,6 +3,7 @@
>  #include "thread.h"
>  #include "map.h"
>  #include "event.h"
> +#include "debug.h"
>  #include "tests/tests.h"
>
>  #define STACK_SIZE 8192
> diff --git a/tools/perf/arch/arm/util/unwind-libunwind.c b/tools/perf/arch/arm/util/unwind-libunwind.c
> index 729ed69..62c397e 100644
> --- a/tools/perf/arch/arm/util/unwind-libunwind.c
> +++ b/tools/perf/arch/arm/util/unwind-libunwind.c
> @@ -3,6 +3,7 @@
>  #include <libunwind.h>
>  #include "perf_regs.h"
>  #include "../../util/unwind.h"
> +#include "../../util/debug.h"
>
>  int libunwind__arch_reg_id(int regnum)
>  {
> diff --git a/tools/perf/arch/arm64/util/unwind-libunwind.c b/tools/perf/arch/arm64/util/unwind-libunwind.c
> index 436ee43..a87afa9 100644
> --- a/tools/perf/arch/arm64/util/unwind-libunwind.c
> +++ b/tools/perf/arch/arm64/util/unwind-libunwind.c
> @@ -3,6 +3,7 @@
>  #include <libunwind.h>
>  #include "perf_regs.h"
>  #include "../../util/unwind.h"
> +#include "../../util/debug.h"
>
>  int libunwind__arch_reg_id(int regnum)
>  {
> --
> 2.1.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/