linux-kernel - Re: [PATCH v2] mptfusion: enable no_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140923071154.GB3867@infradead.org>
Date:	Tue, 23 Sep 2014 00:11:54 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Chris J Arges <chris.j.arges@...onical.com>
Cc:	hch@...radead.org, bruce.lucas@...godb.com,
	Nagalakshmi Nandigama <nagalakshmi.nandigama@...gotech.com>,
	Praveen Krishnamoorthy <praveen.krishnamoorthy@...gotech.com>,
	Sreekanth Reddy <sreekanth.reddy@...gotech.com>,
	Abhijit Mahajan <abhijit.mahajan@...gotech.com>,
	MPT-FusionLinux.pdl@...gotech.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mptfusion: enable no_write_same for vmware scsi disks

Hi Chris,

thanks for updating it, althugh it would need a few more updates.

> +	/* Fix for vmware guests that do not implement write_same
> +         */
> +	if (pdev->subsystem_vendor == 0x15AD) {
> +		mptspi_driver_template.no_write_same = 1;
> +	}
> +

We should set it only on th host that matches, not the whole template
for this case.  The host is allocated just below your statement in
the same function, so this should be easy.

Also no need for braces here, and try to follow the Linux comment style:

	/* The VMWare emulation doesn't properly impement WRITE SAME */
	if (pdev->subsystem_vendor == 0x15AD)
		sh->no_write_same = 1;
		

(and yes, it would be good to have PCI_VENDOR_ID_VMWARE in pci_ids.h,
 but that shouldn't be done in this bug fix patch)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/