linux-kernel - Re: [PATCH 1/2] memcg: move memcg_{alloc,free}_cache_params to slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140923073111.GC3588@esperanza>
Date:	Tue, 23 Sep 2014 11:31:11 +0400
From:	Vladimir Davydov <vdavydov@...allels.com>
To:	Johannes Weiner <hannes@...xchg.org>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	<linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
	Michal Hocko <mhocko@...e.cz>, Christoph Lameter <cl@...ux.com>
Subject: Re: [PATCH 1/2] memcg: move memcg_{alloc,free}_cache_params to
 slab_common.c

On Mon, Sep 22, 2014 at 04:08:25PM -0400, Johannes Weiner wrote:
> On Thu, Sep 18, 2014 at 07:50:19PM +0400, Vladimir Davydov wrote:
> > The only reason why they live in memcontrol.c is that we get/put css
> > reference to the owner memory cgroup in them. However, we can do that in
> > memcg_{un,}register_cache.
> > 
> > So let's move them to slab_common.c and make them static.
> > 
> > Signed-off-by: Vladimir Davydov <vdavydov@...allels.com>
> > Cc: Johannes Weiner <hannes@...xchg.org>
> > Cc: Michal Hocko <mhocko@...e.cz>
> > Cc: Christoph Lameter <cl@...ux.com>
> 
> Cool, so you get rid of the back-and-forth between memcg and slab, and
> thereby also shrink the public memcg interface.

It should be mentioned that we still call memcg_update_array_size()
(defined at memcontrol.c) from memcg_update_all_caches()
(slab_common.c), because we must hold the slab_mutex while updating
memcg_limited_groups_array_size. However, I'm going to remove this
requirement and get rid of memcg_update_array_size() too. This is what
"[PATCH -mm 10/14] memcg: add rwsem to sync against memcg_caches arrays
relocation", which is a part of my "Per memcg slab shrinkers" patch set,
does.

Thanks,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/