linux-kernel - Re: [PATCH] rtc: pm8xxx: rework to support pm8941 rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54213708.7050605@mm-sol.com>
Date:	Tue, 23 Sep 2014 12:02:00 +0300
From:	Stanimir Varbanov <svarbanov@...sol.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, Stephen Boyd <sboyd@...eaurora.org>,
	Josh Cartwright <joshc@...eaurora.org>
Subject: Re: [PATCH] rtc: pm8xxx: rework to support pm8941 rtc

On 09/20/2014 02:03 AM, Andrew Morton wrote:
> On Fri, 12 Sep 2014 12:44:04 +0300 Stanimir Varbanov <svarbanov@...sol.com> wrote:
> 
>> Adds support for RTC device inside PM8941 PMIC. The RTC
>> in this PMIC have two register spaces. Thus the rtc-pm8xxx
>> is slightly reworked to reflect these differences.
>>
>> The register set for different PMIC chips are selected
>> on DT compatible string base.
> 
> checkpatch (which you obviously didn't use!) says
> 
> WARNING: DT compatible string "qcom,pm8941-rtc" appears un-documented -- check ./Documentation/devicetree/bindings/
> #414: FILE: drivers/rtc/rtc-pm8xxx.c:435:
> +       { .compatible = "qcom,pm8941-rtc", .data = &pm8941_regs },

Ahh, sorry for inconvenience I forgot to run checkpatch over this patch.

I will send follow-up patch which will add the compatible string in the
pm8xxx binding document.

-- 
regards,
Stan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/