linux-kernel - Re: [PATCH V5] edac, amd64_edac: Modify usage of amd64_read_dct_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140923111838.GG22072@pd.tnic>
Date:	Tue, 23 Sep 2014 13:18:38 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
Cc:	dougthompson@...ssion.com, m.chehab@...sung.com,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V5] edac, amd64_edac: Modify usage of
 amd64_read_dct_pci_cfg()

On Mon, Sep 15, 2014 at 11:37:38AM -0500, Aravind Gopalakrishnan wrote:
> From: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com>
> 
> Rationale behind this change:
>  - F2x1xx addresses were stopped from being mapped explicitly to DCT1
>    from F15h (OR) onwards. They use _dct[0:1] mechanism to access the
>    registers. So we should move away from using address ranges to select
>    DCT for these families.
>  - On newer processors, the address ranges used to indicate DCT1 (0x140,
>    0x1a0) have different meanings than what is assumed currently.
> 
> Changes introduced:
>  - amd64_read_dct_pci_cfg() now takes in dct value and uses it for
>    'selecting the dct'
>  - Update usage of the function. Keep in mind that different families
>    have specific handling requirements
>  - Remove [k8|f10]_read_dct_pci_cfg() as they don't do much different
>    from amd64_read_pci_cfg()
>    - Move the k8 specific check to amd64_read_pci_cfg
>  - Remove f15_read_dct_pci_cfg() and move logic to amd64_read_dct_pci_cfg()
>  - Remove now needless .read_dct_pci_cfg
> 
> Testing:
>  - Tested on Fam 10h; Fam15h Models: 00h, 30h; Fam16h using 'EDAC_DEBUG'
>    and mce_amd_inj
>  - driver obtains info from F2x registers and caches it in pvt
>    structures correctly
>  - ECC decoding works fine
> 
> Signed-off-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
> ---
> Changes in V5: (per Boris suggestion)
>  - use switch instead of if() in amd64_read_dct_pci_cfg() for better
>    readability.
>  - retain if(!dct_ganging_enabled) condition while reading dclr1.
> 
> Change in V4: (per Boris suggestion)
>  - move amd64_read_dct_pci_cfg() to amd64_edac.c and save exporting
>    f15h_select_dct() in the process
> 
> Changes in V3:
>  - per Boris suggestion
>    - move dct selection logic to amd64_read_dct_pci_cfg()
>    - remove f15_read_dct_pci_cfg() and move logic to amd64_read_dct_pci_cfg()
>  - misc
>    - modify logic in amd64_read_dct_pci_cfg() to keep in mind the specific
>      read handling requirements of different families. Previous version had
>      failed to do that.
> 
> Changes in V2: (per Boris suggestion)
>  - Hide family checks in amd64_read_dct_pci_cfg()
>  - Use pvt structure for family checks and not boot_cpu_data
> 
>  drivers/edac/amd64_edac.c | 146 +++++++++++++++++++++++++---------------------
>  drivers/edac/amd64_edac.h |   5 --
>  2 files changed, 80 insertions(+), 71 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/