linux-kernel - Re: [PATCH] ata: Disabling the async PM for JMicron chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140923140053.GG14905@mtj.dyndns.org>
Date:	Tue, 23 Sep 2014 10:00:53 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Chuansheng Liu <chuansheng.liu@...el.com>
Cc:	rjw@...ysocki.net, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, mister.freeman@...oste.net,
	rui.zhang@...el.com
Subject: Re: [PATCH] ata: Disabling the async PM for JMicron chips

On Tue, Sep 23, 2014 at 01:37:51PM +0800, Chuansheng Liu wrote:
> Be similar with commit (ata: Disabling the async PM for JMicron chip 363/361),

Please use 12_DIGIT_SHA1_PREFIX ("SUBJ") format when referring to
commits.

> Barto found the similar issue for JMicron chip 368, that 363/368 has no
> parent-children relationship, but they have the power dependency.
> 
> So here we can exclude the JMicron chips out of pm_async method directly,
> to avoid further similar issues.
> 
> Details in:
> https://bugzilla.kernel.org/show_bug.cgi?id=84861
> 
> Reported-and-tested-by: Barto <mister.freeman@...oste.net>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> ---
>  drivers/ata/ahci.c         |    6 +++---
>  drivers/ata/pata_jmicron.c |    6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index a0cc0ed..c096d49 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1345,10 +1345,10 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	 * follow the sequence one by one, otherwise one of them can not be
>  	 * powered on successfully, so here we disable the async suspend
>  	 * method for these chips.
> +	 * Jmicron chip 368 has been found has the similar issue, here we can
> +	 * exclude the Jmicron family directly to avoid other similar issues.

Let's update the comment as a whole instead of appending to it.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/