lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Sep 2014 16:10:09 +0200 From: Arnd Bergmann <arnd@...db.de> To: "Joe. C" <srv_yingjoe.chen@...iatek.com> Cc: linux-arm-kernel@...ts.infradead.org, Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org, "Hongzhou. Yang" <srv_hongzhou.yang@...iatek.com>, Vladimir Murzin <vladimir.murzin@....com>, Russell King <linux@....linux.org.uk>, Pawel Moll <pawel.moll@....com>, srv_heupstream@...iatek.com, Ian Campbell <ijc+devicetree@...lion.org.uk>, Hongzhou Yang <hongzhou.yang@...iatek.com>, Catalin Marinas <catalin.marinas@....com>, Linus Walleij <linus.walleij@...aro.org>, Ashwin Chaugule <ashwin.chaugule@...aro.org>, linux-kernel@...r.kernel.org, Grant Likely <grant.likely@...aro.org>, Rob Herring <robh+dt@...nel.org>, Sascha Hauer <kernel@...gutronix.de>, Kumar Gala <galak@...eaurora.org>, Matthias Brugger <matthias.bgg@...il.com>, dandan.he@...iatek.com Subject: Re: [PATCH v2 4/4] ARM: dts: mt8135: Add pinctrl node for mt8135. On Tuesday 23 September 2014 21:58:14 Joe. C wrote: > Thanks for review. > The intend for these macros is helpin pinctrl user to write DT node. > With these macro, we could write like this for i2c0: > > mediatek,pinfunc = <MT8135_PIN_100_SDA0__FUNC_SDA0 > MT8135_PIN_101_SCL0__FUNC_SCL0>; > > We feel this is less error prone and easier to write than this: > > mediatek,pinfunc = <MT_PIN_FUNC(100, 1) MT_PIN_FUNC(101, 1)> But you don't actually use the same macros in the driver, so in effect you just move the definitions from the file they are needed in to another file as a macro. It is no less error prone to define those macros in mt8135-pinfunc.h than in the pinctrl node, just less readable. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists